How you share files is dependent on who, what, and how you are expecting to share them.
For instance:
Share on a local network with Windows PCs, yes. Samba is a good way to do this if the Samba server won't be turned off or put in sleep mode.
Share with other Linux servers on a local network, no. NFS might be a better option if you do not expect the NFS server to be turned off / sleep mode.
Share files over the Internet. A cloud service might be a better way to share them.
Share files across a local network with many different types of machines. Samba might be okay. You could also setup an SFTP server.